Unification of categories and functors#193
Merged
Merged
Conversation
3d39878 to
dd16d4f
Compare
2cc7397 to
36fc74a
Compare
60b6102 to
a35c3e8
Compare
01451f2 to
411068c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the frontend counterpart of #191. It is a major refactor of the whole frontend.
All functions, types, Svelte components, and Svelte pages that were previously defined separately for categories and functors (often with slight differences) have been unified. This eliminates a significant amount of code duplication, ensures that both categorical structures are handled consistently, and provides a foundation for supporting further categorical structures (#4) in the future.
In the process of aligning the pages, some features have been added to functors that were previously only available for categories:
The unification is not finished yet: most database queries have not been unified. And those that have been unified (for example, for the search feature and the deduction scripts) are somewhat brittle, as they use string injection to construct a query that depends on the structure type (typical example:
SELECT id FROM ${type}_properties). This will be improved in another PR.