Various UI improvements#221
Merged
Merged
Conversation
ScriptRaccoon
force-pushed
the
selection-focus
branch
from
ca0bf86 to
ca5ecb3
Compare
replacing 100vh with 100dvh is already the fix, but 90dvh is perhaps better UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search Page / Comparison Page
Of course, the code already checked for this internally, but users could still bypass it. This is now prevented.
Walking structures
The notation for walking structures has been changed and is now more consistent. Instead of using "diagrams" to represent the notation, symbols such as Isom and Pair are now used (similar to the existing Idem and Split notation). Their descriptions have also been improved.
The updated notations fix layout issues on the comparison page on mobile devices when many of these walking structures are selected.
Navigation
On mobile devices, the structure selector ("categories" / "functors") has been moved from the header into the navigation component behind the hamburger menu.
Header styles have been adjusted slightly.
Long proofs
There was a visual bug: very long proofs displayed in popups were cut off at the top on mobile devices. The reason was that the maximal height was set to
100vh, whereas it actually needed to be100dvhin order to account for the mobile browser UI. In fact, this has now been changed to90dvhso that a bit of page context remains visible.Another way to address the issue of very large and scrollable popups is to move proofs to dedicated content pages, which has been done in some cases. This also makes it possible to group related proofs together.
The seed script now checks for long proofs (threshold: 1200 characters) and prints a warning for each of them. Intentionally, no error is thrown, since some proofs are somewhat long but still do not justify a dedicated content page.