Skip to content

Add more database checks#61

Merged
ScriptRaccoon merged 3 commits intomainfrom
add-more-checks
Apr 12, 2026
Merged

Add more database checks#61
ScriptRaccoon merged 3 commits intomainfrom
add-more-checks

Conversation

@ScriptRaccoon
Copy link
Copy Markdown
Owner

@ScriptRaccoon ScriptRaccoon commented Apr 12, 2026

  • Automatically test that all of the categories mentioned below have all properties decided. This is to ensure a good database quality. In particular, when a PR adds a new property, that property needs to be decided for at least these categories.
[
	"0",
	"1",
	"2",
	"Ab",
	"Grp",
	"N",
	"R-Mod",
	"CRing",
	"Ring",
	"Set",
	"Set*",
	"Top",
	"Top*",
	"Vect",
	"walking_morphism"
]
  • Refactor the test script
  • Add JSDocs to all functions in the test script
  • Improve the contribution guidelines: better explanation of the tests
  • Add a workflow file to run the update script, which includes the test script, in the ephemeral runner environment. For now this only runs with a manual trigger, since I want to test this first. In the future, every PR will run this automatically.

Remark: if these checks turn out to be too strict, we can iterate. For example, we might introduce a threshold of unknown (category, property)-pairs.

PS: This is how the output looks like.

test command screenshot

@ScriptRaccoon ScriptRaccoon marked this pull request as ready for review April 12, 2026 23:29
@ScriptRaccoon ScriptRaccoon merged commit fcfb6c1 into main Apr 12, 2026
@ScriptRaccoon ScriptRaccoon deleted the add-more-checks branch April 12, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant