Improve TraceDecay skill adoption steering#225
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73147715ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
135bbcc to
234dd41
Compare
f0c5c36 to
d422749
Compare
ClaudeSource scans every ~/.claude/projects slug and filters rows by recorded cwd, but parse_new returned None when every row was filtered out, so the cursor never advanced for transcripts belonging to other projects (or for appended non-message rows). Every sweep re-read and re-git-probed the entire foreign corpus, O(total transcript bytes x projects) instead of one pass. Returning the empty transcript lets ingest_one persist the advanced cursor without upserting a session, the same contract cline/kiro already use. Also fixes issues surfaced while sanity-checking today's merged PRs: - docs: scrub /home/zack absolute paths from the Hermes parity audit, elide the local analytics project id, and note that the skill-catalog consolidation recommended by SKILL-ADOPTION-RESEARCH.md was implemented by #225 (its skill names describe the old catalog) - agents: point code-health-auditor at tracedecay:code-health (the code-health-report skill was retired in the restructure) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ClaudeSource scans every ~/.claude/projects slug and filters rows by recorded cwd, but parse_new returned None when every row was filtered out, so the cursor never advanced for transcripts belonging to other projects (or for appended non-message rows). Every sweep re-read and re-git-probed the entire foreign corpus, O(total transcript bytes x projects) instead of one pass. Returning the empty transcript lets ingest_one persist the advanced cursor without upserting a session, the same contract cline/kiro already use. Also fixes issues surfaced while sanity-checking today's merged PRs: - docs: scrub /home/zack absolute paths from the Hermes parity audit, elide the local analytics project id, and note that the skill-catalog consolidation recommended by SKILL-ADOPTION-RESEARCH.md was implemented by #225 (its skill names describe the old catalog) - agents: point code-health-auditor at tracedecay:code-health (the code-health-report skill was retired in the restructure) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Summary
Validation
Note: the first cargo test attempt failed before repo tests because inherited TMPDIR=/scratch/tmp made libsql-ffi's assembler miss a temp file. Rerunning with TMPDIR=/tmp passed.