Value Equals fix; switch style fix #13
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ValueSystem/CollectionValue.cs
Outdated
| } = null!; | ||
|
|
||
|
|
||
| public override bool EqualCondition(Value other) => other is CollectionValue otherP && CastedValues.SequenceEqual(otherP.CastedValues) && Type == otherP.Type; |
There was a problem hiding this comment.
logic: SequenceEqual uses default equality comparison which may not invoke the custom EqualCondition methods on Value elements. Consider using a custom comparer or manually iterating through elements to call EqualCondition. Should the collection equality check use the custom EqualCondition method for comparing individual Value elements instead of relying on default equality?
Prompt To Fix With AI
This is a comment left during a code review.
Path: ValueSystem/CollectionValue.cs
Line: 53:53
Comment:
**logic:** SequenceEqual uses default equality comparison which may not invoke the custom EqualCondition methods on Value elements. Consider using a custom comparer or manually iterating through elements to call EqualCondition. Should the collection equality check use the custom EqualCondition method for comparing individual Value elements instead of relying on default equality?
How can I resolve this? If you propose a fix, please make it concise.
There was a problem hiding this comment.
@Tosoks67 weź rzuć okiem na to, chyba dobry catch
There was a problem hiding this comment.
dodany fix do pull requesta
ValueSystem/ReferenceValue.cs
Outdated
| public bool IsValid => value is not null; | ||
| public object Value => value ?? throw new ScriptRuntimeError("Value of reference is invalid."); | ||
|
|
||
| public override bool EqualCondition(Value other) => other is ReferenceValue otherP && Value.Equals(otherP.Value); |
There was a problem hiding this comment.
logic: Calling Value property on invalid references will throw ScriptRuntimeError. Consider checking IsValid on both references before accessing Value properties to avoid exceptions during equality comparisons. Should equality comparison between invalid references return false, or should it throw an exception as currently implemented?
Prompt To Fix With AI
This is a comment left during a code review.
Path: ValueSystem/ReferenceValue.cs
Line: 11:11
Comment:
**logic:** Calling `Value` property on invalid references will throw `ScriptRuntimeError`. Consider checking `IsValid` on both references before accessing `Value` properties to avoid exceptions during equality comparisons. Should equality comparison between invalid references return false, or should it throw an exception as currently implemented?
How can I resolve this? If you propose a fix, please make it concise.
2 participants
Added an abstract bool method
EqualConditiontoValue(takesValueas the only parameter; It's basically the condition that's checked in theEqualsoverride and the==and!=)made the switches look good (perfectionist ahh)