Open
Conversation
Contributor
|
Nice job - I'll review this a bit more later and see if I have any feedback, but, at first glance, I see there are a few .orig and .rej files that crept in. Can you remove those? |
Author
|
Yes I noticed, that’s why I reverted it to being a draft again. I will remove them, don’t worry. Please review thoroughly, I have tested this and I can run scrollz, I also connected to a server and wrote messages. But I haven’t tested every single function. Also take your time, release of clang16 is 2024 I think |
Contributor
|
No problem. It's a big task!
Just a hint, use `SZdist` and test all the various option combinations as well, just be sure.
Of course, Flier will have the final word on it, but if it doesn't change or break any functionality it should pass his review, if all done well.
…On Tue, Nov 15, 2022, at 1:38 PM, Pascal J wrote:
Yes I noticed, that’s why I reverted it to being a draft again. I will remove them, don’t worry.
Please review thoroughly, I have tested this and I can run scrollz, I also connected to a server and wrote messages. But I haven’t tested every single function.
Also take your time, release of clang16 is 2024 I think
—
Reply to this email directly, view it on GitHub <#30 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOWGFJQX2BIOFLS3VFKKGCDWIPKB3ANCNFSM6AAAAAASBD6FDU>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Schievel1
force-pushed
the
patch-clang16-lto
branch
2 times, most recently
from
4f51339 to
ded5add
Compare
Author
|
Oh and I also wrote a mail to flier@scrollz.info because I did not know there is a repo on github. So, please ignore the mail... |
Clang16 will not allow implicit int, implicit function declaration etc. by default. This overhauls the whole source code to work with clang16 default. Also fixes some -Werror=lto-type-mismatch I also used modern C function definitions everywhere. See also: https://bugs.gentoo.org/870907 https://bugs.gentoo.org/861467 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
Schievel1
force-pushed
the
patch-clang16-lto
branch
from
ded5add to
4e8b065
Compare
Contributor
|
Bump (for my TODO list) |
Contributor
|
Re-bumping. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang16 will not allow implicit int, implicit function declaration etc. by default.
This overhauls the whole source code to work with clang16 default.
Also fixes some -Werror=lto-type-mismatch
I also used modern C function definitions everywhere.
See also:
https://bugs.gentoo.org/870907
https://bugs.gentoo.org/861467
Signed-off-by: Pascal Jäger pascal.jaeger@leimstift.de