refactor!: update schema to GIM_QUERY/GIM_RESPONSE#42
Merged
Conversation
This commit introduces a breaking change by renaming `M_INPUT` to `GIM_QUERY` and `M_OUTPUT` to `GIM_RESPONSE`. It also includes several fixes and improvements: - Refactor: Replace hardcoded magic strings with constants defined in `schemas.py`. - Fix: Improve the `stringify` method of `Query()` and `Response()` for better clarity and robustness. - Fix: Resolve an issue in `parse_parts` when handling tags with and without IDs. - Refactor: Update `dataset/` and `data-viewer.html` to align with the schema changes. - Fix: Address type hints and resolve `mypy` issues. These changes ensure better maintainability and consistency across the codebase.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a breaking change by renaming
M_INPUTtoGIM_QUERYandM_OUTPUTtoGIM_RESPONSE. It also includes several fixes and improvements:schemas.py.stringifymethod ofQuery()andResponse()for better clarity and robustness.parse_partswhen handling tags with and without IDs.dataset/anddata-viewer.htmlto align with the schema changes.mypyissues.These changes ensure better maintainability and consistency across the codebase.