Skip to content

refactor: update model input and output types to use ContextInput and Result#64

Merged
Ki-Seki merged 2 commits intomainfrom
refactor/model-io-type
Oct 2, 2025
Merged

refactor: update model input and output types to use ContextInput and Result#64
Ki-Seki merged 2 commits intomainfrom
refactor/model-io-type

Conversation

@Ki-Seki
Copy link
Member

@Ki-Seki Ki-Seki commented Oct 2, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 2, 2025 09:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the model input and output types to improve type safety and consistency across the codebase. The changes standardize the handling of context inputs and model outputs by introducing clearer type definitions and a unified approach to result generation.

Key changes:

  • Replace Response type with Result type for model outputs
  • Standardize model input types to use ContextInput type alias
  • Update result creation to use infill() function instead of direct Response() construction

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/models/test_openai.py Updates test assertions to use Result instead of Response type
src/gimkit/models/utils.py Refactors input/output types and changes result creation to use infill()
src/gimkit/models/openai.py Updates type annotations to use new ContextInput and Result types
examples/gimkit_quickstart.py Modernizes example to use model integration instead of manual LLM requests
examples/cases.ipynb Updates notebook examples to use new model interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Ki-Seki Ki-Seki merged commit 2b724aa into main Oct 2, 2025
6 checks passed
@Ki-Seki Ki-Seki deleted the refactor/model-io-type branch October 2, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants