refactor: update model input and output types to use ContextInput and Result#64
Merged
refactor: update model input and output types to use ContextInput and Result#64
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the model input and output types to improve type safety and consistency across the codebase. The changes standardize the handling of context inputs and model outputs by introducing clearer type definitions and a unified approach to result generation.
Key changes:
- Replace
Responsetype withResulttype for model outputs - Standardize model input types to use
ContextInputtype alias - Update result creation to use
infill()function instead of directResponse()construction
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/models/test_openai.py | Updates test assertions to use Result instead of Response type |
| src/gimkit/models/utils.py | Refactors input/output types and changes result creation to use infill() |
| src/gimkit/models/openai.py | Updates type annotations to use new ContextInput and Result types |
| examples/gimkit_quickstart.py | Modernizes example to use model integration instead of manual LLM requests |
| examples/cases.ipynb | Updates notebook examples to use new model interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.