Conversation
Dabnsky
requested review from
Ferelith-maker,
brayan-trejo,
foodprocessor and
jfantinhardesty
as code owners
foodprocessor
requested changes
Nov 1, 2024
…le into the /etc/systemd/system/
jfantinhardesty
requested changes
Nov 18, 2024
-changed collectServiceData() to extractValue() that outputs value from file for provided key -changed setUser() to use SUDO_USER env variable to add to service user group. and adjusted permissions for service user.
-corrected typo of moutingpoint that came from cloudfuse.service template file
foodprocessor
requested changes
Jan 16, 2025
jfantinhardesty
requested changes
Jan 23, 2025
Contributor
jfantinhardesty
left a comment
jfantinhardesty
left a comment
There was a problem hiding this comment.
Looks pretty close. A few things to fix:
- The linter is giving errors. Fix the lint issues in this file so that all of the tests in GitHub actions are green.
- The uninstall command does not work. You set serviceName in the uninstall command options when the user passes in mount-path but then don't use it and refer to the mountPath variable in the uninstallCmd function so then you are not able to uninstall the service. You should probably remove the serviceName and just use the mountPath variable. Test to make sure that this change works.
- On line 220, that fmt.Println should not end with a newline character since this is newline it will insert one automatically.
- You should merge main into this branch and then update the copyright header so it is 2023-2025.
…e-service-linux-cmd
jfantinhardesty
approved these changes
Jan 28, 2025
Contributor
Author
|
datalake error fixed in separate PR that was holding up the last code coverage test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This adds the following commands available to the cloudfuse executable:
cloudfuse service install
cloudfuse service uninstall
Checklist
Related Issues