Use Bucket Size for Filesystem Stats#358
Conversation
libfuse2: Always use configured display capacity
Use new flag to choose which component provides StatFs info.
Bugfix: return zero for free and avail so libfuse knows cloud storage is responding.
There was a problem hiding this comment.
Great fix for the size of the bucket. On question, is there a performance concern with how often the OS may call statfs. Seems like it might be a bit slow to respond each time and was wondering if this has caused a problem with Network Optix or if you see a problem with the additional latency? Also it appears that the test TestStatFs is failing on both Linux and Windows.
I have tested this on both platforms. I have not seen performance issues (cloud responds in less than 100ms), and the OS seems to only call StatFs at the expected times (when viewing the mount properties and when an application calls StatFs explicitly). |
jfantinhardesty
left a comment
There was a problem hiding this comment.
Looks good! I like the config option in s3storage.
Describe your changes in brief
StatFswill be populated by file cache or cloud storage.StatFsstorage usage statistics from cloud storage by default (should we flip this, or should the flag be in s3storage?)StatFsmath in file cache.StatFsfunction in file cache regardless of platform (and usegetAvailableSize()for platform-specific code).StatFsresponse to handle both file cache and cloud storage data.HeadBucketto capture response and parse size (works for Lyve Cloud only).bucketExists()to replace oldheadBucketwrapper.What type of Pull Request is this? (check all applicable)
Checklist
Related Issues