Skip to content

Add remount flag#469

Merged
jfantinhardesty merged 8 commits intomainfrom
add-remount-flag
Mar 4, 2025
Merged

Add remount flag#469
jfantinhardesty merged 8 commits intomainfrom
add-remount-flag

Conversation

@jfantinhardesty
Copy link
Copy Markdown
Contributor

@jfantinhardesty jfantinhardesty commented Mar 4, 2025

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

This adds an enable-remount flag and a disable-remount flag to the command line. Additionally, it adds the option to enable this flag in the GUI as well. This also fixes a bug where we had bad bookkeeping in the mounts.json file.

image

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

Copy link
Copy Markdown
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change needed!

Comment thread cmd/mount.go Outdated
Comment thread gui/mountPrimaryWindow.py Outdated
@jfantinhardesty jfantinhardesty merged commit 52d2a51 into main Mar 4, 2025
3 checks passed
@jfantinhardesty jfantinhardesty deleted the add-remount-flag branch March 4, 2025 16:56
Copy link
Copy Markdown
Contributor

@Ferelith-maker Ferelith-maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the GUI part

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants