Fix issue with secure config failed due to incorrectly decoding the b…#471
Merged
jfantinhardesty merged 3 commits intomainfrom Mar 6, 2025
Merged
Fix issue with secure config failed due to incorrectly decoding the b…#471jfantinhardesty merged 3 commits intomainfrom
jfantinhardesty merged 3 commits intomainfrom
Conversation
…ase64 string, and allow for env variable when passing passphrase when generating config
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker and
foodprocessor
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ase64 string, and allow for env variable when passing passphrase when generating config
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This fixes several issues with encrypted config files. First it fixes a bug from switching to memguard where we did not decode the passphrase string from base64 which could cause error with some encryption keys. Additionally, we allow using gen-config command with the passphrase environment variable.
Checklist
Related Issues