Skip to content

Block cache windows#494

Merged
jfantinhardesty merged 24 commits intomainfrom
block-cache-windows
Apr 15, 2025
Merged

Block cache windows#494
jfantinhardesty merged 24 commits intomainfrom
block-cache-windows

Conversation

@jfantinhardesty
Copy link
Copy Markdown
Contributor

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

Add support for block_cache on Windows! Also adds tests in our CI/CD pipeline for block_cache.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

@jfantinhardesty jfantinhardesty marked this pull request as draft March 28, 2025 22:39
@jfantinhardesty jfantinhardesty marked this pull request as ready for review April 1, 2025 22:43
Copy link
Copy Markdown
Contributor

@Dabnsky Dabnsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! I learned allot from this one

Comment thread component/block_cache/block_cache.go
Comment thread component/block_cache/block_cache.go
Comment thread component/block_cache/block_cache_test.go Outdated
Copy link
Copy Markdown
Contributor

@foodprocessor foodprocessor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jfantinhardesty jfantinhardesty merged commit bed4fa7 into main Apr 15, 2025
18 of 21 checks passed
@jfantinhardesty jfantinhardesty deleted the block-cache-windows branch April 15, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants