Merged
Conversation
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker and
foodprocessor
as code owners
Ferelith-maker
approved these changes
Apr 8, 2025
Dabnsky
reviewed
Apr 10, 2025
Dabnsky
reviewed
Apr 10, 2025
Dabnsky
reviewed
Apr 10, 2025
Dabnsky
approved these changes
Apr 10, 2025
Contributor
Dabnsky
left a comment
Dabnsky
left a comment
There was a problem hiding this comment.
Looks great. Just some old strings that need updating. I think my log collector will need to be adjusted to also default to base to conform with this merge..
![mend-for-github-com[bot]](https://avatars.githubusercontent.com/in/30796?s=60&v=4){kind=small}
foodprocessor
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
Add sensible defaults. This changes our default displayed capacity and switches to base logging instead of syslog.
Checklist
Related Issues