Stop using parameters as code comments #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foodprocessor
requested review from
Dabnsky,
Ferelith-maker and
jfantinhardesty
as code owners
Drop renameCachedFile().
foodprocessor
changed the title
jfantinhardesty
approved these changes
May 5, 2025
jfantinhardesty
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions in file cache take file lock items as parameters, just to signal to the coder that the lock should be acquired before calling the function. This change removes that and replaces it with code comments.
This also improves and simplifies file rename logic.
The biggest change in the logic is that we no longer reverse a rename when the local rename fails. Instead, we just delete the local source file and point any open handles to the new name.
This allows us to complete renames in more cases, without any risk of data loss.