Remove redundant WREQ module definition in error.rs#5
Merged
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on error/exception handler implementation
Remove redundant WREQ module definition in error.rs
Nov 18, 2025
0x676e67
added a commit
that referenced
this pull request
Nov 18, 2025
* feat(error): add error/exception handler * update * fmt * update * Update src/error.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/error.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/error.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Initial plan (#5) * Initial plan (#6) * fmt * fmt --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
0x676e67
added a commit
that referenced
this pull request
Nov 19, 2025
* feat(error): add error/exception handler * update * fmt * update * Update src/error.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/error.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/error.rs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Initial plan (#5) * Initial plan (#6) * fmt * fmt * fmt --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #4 where
src/error.rsredundantly calleddefine_modulefor theWREQmodule already defined inlib.rs.Changes
static WREQ: Lazy<RModule>that was redefining the moduledefine_exception!to useconst_get()to look up the existing module instead of defining iterror::include()to acceptgem_moduleparameter and returnResult<(), MagnusError>, matching the pattern inhttp::include()andclient::include()Before:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.