Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ arc-swap = "1.9.1"
http = "1.4.0"
http-body-util = "0.1.3"
futures-util = { version = "0.3.32", default-features = false }
percent-encoding = "2.3.2"

[build-dependencies]
rb-sys-env = "0.2.2"
Expand Down
7 changes: 2 additions & 5 deletions src/extractor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,6 @@ impl ExtractorName for Vec<HeaderValue> {

impl TryConvert for Extractor<Vec<HeaderValue>> {
fn try_convert(value: magnus::Value) -> Result<Self, magnus::Error> {
use percent_encoding::{NON_ALPHANUMERIC, percent_encode};

let ruby = Ruby::get_with(value);
let keyword = RHash::try_convert(value)?;

Expand All @@ -157,9 +155,8 @@ impl TryConvert for Extractor<Vec<HeaderValue>> {
{
let mut cookies = Vec::new();
hash.foreach(|name: RString, value: RString| {
let value = value.to_bytes();
let encoded_value = percent_encode(&value, NON_ALPHANUMERIC);
let cookie = format!("{name}={encoded_value}");
let value = value.to_string()?;
let cookie = format!("{name}={value}");
let header_value = HeaderValue::from_maybe_shared(Bytes::from(cookie))
.map_err(header_value_error_to_magnus)?;
cookies.push(header_value);
Expand Down
2 changes: 1 addition & 1 deletion test/cookie_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,6 @@ def test_request_cookie_value_percent_encoding
"http://localhost:8080/cookies",
cookies: {"mykey" => raw_value}
)
assert_includes resp.text, "hello%20world%3F"
assert_includes resp.text, "hello world?"
end
end