Skip to content

Create Options Page#5

Merged
Sebazzz merged 5 commits intoSebazzz:masterfrom
mitsakosgr:master
Apr 9, 2021
Merged

Create Options Page#5
Sebazzz merged 5 commits intoSebazzz:masterfrom
mitsakosgr:master

Conversation

@mitsakosgr
Copy link

  • Fixed Icons (corrupted)
  • Added options page for Proxy host/port
  • Added options to filter urls to send to proxy

Partially closes #1, except auto reloading PAC when settings are changed. User needs to manually disable and re-enable the proxy (clicking twice on extension).

@Sebazzz
Copy link
Owner

Sebazzz commented Apr 9, 2021

Excellent, will look at it after work 😄

"default_area": "tabstrip" causes it to be placed next to tabs, instead of plugins
@Sebazzz
Copy link
Owner

Sebazzz commented Apr 9, 2021

Unfortunately it does not work, or not for me at least (Firefox 88b8).

Icon is broken:
image

This possibly also causes the toolbar icon not to appear.

Possible issues (but I haven't checked whether these weren't present already) causing the toolbar icon not to appear:
image

The PNG files appear to be corrupted.

@mitsakosgr
Copy link
Author

It doesn't work for me either. It must have been something with git and how it handles the files. I'll try to add an svg and see the results.

@Sebazzz
Copy link
Owner

Sebazzz commented Apr 9, 2021

Might be due to the .gitattributes file.

@mitsakosgr
Copy link
Author

I replaced png with an svg. Give it a try again please.

@mitsakosgr
Copy link
Author

Might be due to the .gitattributes file.

According to these
https://stackoverflow.com/a/29508751
https://blog.jongallant.com/2021/02/png-files-not-rendering-on-github/

* text eol=lf alone will corrupt png files because they are not detected as binary.
You ahould also add *.png binary to treat them as binary files.
https://gist.github.com/dpalomar/ebc64d6f56cfc25a3e5c20fe7cdfbd4f

If the svg works, I think, it is better because of the smaller size and text format. I don't know about performance, but I don't think it is an issue for this case!

@Sebazzz Sebazzz merged commit 0c9b9d4 into Sebazzz:master Apr 9, 2021
@Sebazzz
Copy link
Owner

Sebazzz commented Apr 9, 2021

Excellent work! I've added a stylesheet to the settings page, so it fits in nicely in the add-ons page. Published at v1.0.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow setting the Fiddler host and port number

2 participants