-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): bump actions/checkout from 5 to 6 #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kevalyq
merged 1 commit into
main
from
dependabot-github_actions-main-actions-checkout-6
Nov 21, 2025
Merged
chore(deps): bump actions/checkout from 5 to 6 #204
kevalyq
merged 1 commit into
main
from
dependabot-github_actions-main-actions-checkout-6
Nov 21, 2025
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
💡 Tip: Consider Using Draft PRsBenefits of opening PRs as drafts initially:
How to convert:
This is just a friendly reminder - feel free to continue as is! 😊 |
|
This is a MAJOR version update which may contain breaking changes. Action required:
Current auto-merge policy (Phase 1):
See policy: |
kevalyq
added a commit
to SecPal/.github
that referenced
this pull request
Nov 21, 2025
Problem: - Codecov was configured with require_ci_to_pass: true - This caused Dependabot PRs to fail codecov checks even though: - GitHub Actions workflows use continue-on-error for dependabot - Token uploads may fail for security reasons - All other CI checks pass successfully Solution: - Set require_ci_to_pass: false (GitHub Actions is already a required check) - Set if_ci_failed: success (don't block PRs if CI has issues) - Set wait_for_ci: false (don't wait for all CI to complete) This allows Dependabot PRs to merge when all GitHub Actions pass, even if codecov upload encounters issues due to missing secrets. Fixes: SecPal/api#204 Fixes: SecPal/frontend#181 Fixes: SecPal/frontend#182 Fixes: SecPal/frontend#183 Fixes: SecPal/frontend#184 Fixes: SecPal/frontend#185
kevalyq
added a commit
to SecPal/.github
that referenced
this pull request
Nov 21, 2025
Problem: - Dependabot PRs in api and frontend were blocked by codecov checks - Root cause: require_ci_to_pass: true + continue-on-error in workflows - Codecov interpreted skipped uploads as failed CI and blocked PRs Initial approach (WRONG): - Set if_ci_failed: success - This would disable coverage enforcement for ALL PRs - Violates Critical Rule #10 (Code Coverage Enforcement) Correct solution: - Set require_ci_to_pass: false (GitHub Actions is required check) - Set informational: true for project/patch coverage - Keep if_ci_failed: error (accurate status reporting) This allows: ✅ Dependabot PRs auto-merge when GitHub Actions pass ✅ Coverage data remains visible and tracked ✅ No coverage enforcement bypass (informational ≠ disabled) ✅ Manual review can still catch coverage drops Technical distinction: - if_ci_failed: success → reports success even with <80% coverage - informational: true → reports status but doesn't block PRs Fixes: SecPal/api#204 Fixes: SecPal/frontend#181 Fixes: SecPal/frontend#182 Fixes: SecPal/frontend#183 Fixes: SecPal/frontend#184 Fixes: SecPal/frontend#185
kevalyq
added a commit
to SecPal/.github
that referenced
this pull request
Nov 21, 2025
Problem: - Dependabot PRs in api and frontend were blocked by codecov checks - Root cause: require_ci_to_pass: true caused Codecov to wait for CI - Dependabot PRs use continue-on-error for uploads (no token access) - Codecov saw no upload data and blocked PRs indefinitely Solution: - Set require_ci_to_pass: false (Codecov won't wait for CI) - Keep informational: false (coverage REMAINS REQUIRED for normal PRs) - Keep if_ci_failed: error (accurate status reporting) How this works: ✅ Normal PRs: Upload succeeds → Coverage calculated → Must meet 80% ✅ Dependabot PRs: Upload skipped → No data → Codecov doesn't block ✅ Coverage enforcement maintained for developers ✅ No security compromise (continue-on-error preserved) Manual step required:⚠️ Mark codecov as optional check in GitHub Branch Protection to allow Dependabot merges when no coverage data exists Related PRs (will auto-merge after this fix): - SecPal/api#204 - SecPal/frontend#181, #182, #183, #184, #185
kevalyq
added a commit
to SecPal/.github
that referenced
this pull request
Nov 21, 2025
* fix(codecov): allow Dependabot PRs without blocking coverage enforcement Problem: - Dependabot PRs in api and frontend were blocked by codecov checks - Root cause: require_ci_to_pass: true caused Codecov to wait for CI - Dependabot PRs use continue-on-error for uploads (no token access) - Codecov saw no upload data and blocked PRs indefinitely Solution: - Set require_ci_to_pass: false (Codecov won't wait for CI) - Keep informational: false (coverage REMAINS REQUIRED for normal PRs) - Keep if_ci_failed: error (accurate status reporting) How this works: ✅ Normal PRs: Upload succeeds → Coverage calculated → Must meet 80% ✅ Dependabot PRs: Upload skipped → No data → Codecov doesn't block ✅ Coverage enforcement maintained for developers ✅ No security compromise (continue-on-error preserved) Manual step required:⚠️ Mark codecov as optional check in GitHub Branch Protection to allow Dependabot merges when no coverage data exists Related PRs (will auto-merge after this fix): - SecPal/api#204 - SecPal/frontend#181, #182, #183, #184, #185 * docs: update CHANGELOG with automated branch protection fix - Added note that codecov/patch was removed from required checks - Removed manual step warning (automated via gh api) - Added configure-codecov-optional.sh script for reference Branch protection updated for: - SecPal/api: codecov/patch removed ✓ - SecPal/frontend: codecov/patch removed ✓ * refactor: address remaining Copilot review comments - Consolidate duplicate comments in .codecov.yml (DRY principle) - Fix PR reference format consistency in CHANGELOG - Clarify branch protection timeline (manual execution) - Fix script logic to handle codecov-only check scenarios - Improve grammar in CHANGELOG list formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependabot
Pull requests created by Dependabot
dependencies
Pull requests that update a dependency file
github-actions
GitHub Actions workflow dependencies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 5 to 6.
Release notes
Sourced from actions/checkout's releases.
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
1af3b93update readme/changelog for v6 (#2311)71cf226v6-beta (#2298)069c695Persist creds to a separate file (#2286)ff7abcdUpdate README to include Node.js 24 support details and requirements (#2248)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)