Don't crash migrations under non-superuser if hstore is not installed #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Photonios
approved these changes
Dec 13, 2017
Contributor
Photonios
left a comment
Photonios
left a comment
There was a problem hiding this comment.
Excellent! Thanks for the PR :)
Contributor
Author
|
Thanks for merging! When will you be able to release this to PyPI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psqlextra's
DatabaseWrapper.prepare_database()attempts to executeCREATE EXTENSION IF NOT EXISTS hstore.The problem is, when the Postgres user is not a superuser, this crashes with a
ProgrammingError, which doesn't allow any migrations to run even if noHStoreFields are used in the models.This pull request changes the behavior to print a log message in this case instead of crashing.