Skip to content
This repository was archived by the owner on Jan 12, 2022. It is now read-only.

Add upgrade support#17

Merged
hrpatel merged 13 commits intodevelopfrom
feature/upgrade
Oct 5, 2018
Merged

Add upgrade support#17
hrpatel merged 13 commits intodevelopfrom
feature/upgrade

Conversation

@hrpatel
Copy link
Copy Markdown
Contributor

@hrpatel hrpatel commented Oct 1, 2018

No description provided.

- Update moodledata permission here
- Improve comments
- Use shtdlib echo statements
- Add logic for upgrading containers
@hrpatel hrpatel requested review from antevens and mroote October 1, 2018 18:26
@hrpatel hrpatel self-assigned this Oct 1, 2018
@antevens
Copy link
Copy Markdown

antevens commented Oct 1, 2018

+1

antevens
antevens previously approved these changes Oct 1, 2018
Copy link
Copy Markdown

@antevens antevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hrpatel
Copy link
Copy Markdown
Contributor Author

hrpatel commented Oct 2, 2018

Sorry guys. Had to commit a change to get CI to pass - please review again.

@antevens
Copy link
Copy Markdown

antevens commented Oct 2, 2018

I don't think you need another review/approval :D

Comment thread nginx-php-moodle/bin/configure-moodle.sh
@hrpatel
Copy link
Copy Markdown
Contributor Author

hrpatel commented Oct 2, 2018

@antevens I configured GH to revoke an approval if commits are added after an approval

antevens
antevens previously approved these changes Oct 2, 2018
Copy link
Copy Markdown
Contributor

@mroote mroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hrpatel hrpatel merged commit bf18283 into develop Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants