fix: only keep unique frames in FrameCoverage object#10
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FrameCoverage class to ensure only unique frames are stored, fixing issues #9 and #67. The changes optimize memory usage by deduplicating frames during initialization rather than on each access.
- Moved
get_frame_covfunction fromloader.pytoframe_cov.pyfor better module organization - Modified
FrameCoverageto accept a recording path instead of pre-loaded frames and deduplicate frames during initialization - Updated version number from 0.1.1 to 0.1.2
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/gamecov/loader.py | Removed get_frame_cov function and unused imports |
| src/gamecov/frame_cov.py | Refactored FrameCoverage constructor and moved get_frame_cov function here |
| src/gamecov/init.py | Updated imports to reflect function relocation |
| pyproject.toml | Bumped version number to 0.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #9 and thereby should fix https://github.com/SecurityLab-UCD/game-fuzz/issues/67.