[TP-198470] Update to Nanoc v4#91
Merged
ssawyer1024 merged 2 commits intomasterfrom Jan 17, 2025
Merged
Conversation
Contributor
ssawyer1024
commented
Jan 16, 2025
ssawyer1024
commented
- [TP-198470] Update gemfiles to "modern" ruby/gems and nanoc4
- [TP-198470] Minimal changes for nanoc v3 -> v4 migration to get the site up and running.
ssawyer1024
force-pushed
the
sawyer/update/tp-198470-update-nanoc-to-v4
branch
2 times, most recently
from
8cae46e to
5d0c6c0
Compare
Contributor
Author
AndrewHYi
reviewed
Jan 16, 2025
Contributor
There was a problem hiding this comment.
.ruby-versionis set to2.4.1., should be upgrade that to ruby 3?- The version specified in
.ruby-versionwasn't being picked up by asdf. I had to set legacy mode true . Should we switch to using.tool-versions? - This project was bundled with an old bundler version. Should we upudate bundler to v. 2?
bundle update --bundler
ssawyer1024
force-pushed
the
sawyer/update/tp-198470-update-nanoc-to-v4
branch
from
5d0c6c0 to
cf03dca
Compare
…ite up and running.
ssawyer1024
force-pushed
the
sawyer/update/tp-198470-update-nanoc-to-v4
branch
from
cf03dca to
1fb89b4
Compare
Contributor
Author
Fixed.
Added.
Fixed. |
Contributor
Author
|
@AndrewHYi It should work properly now. Combination of not quite getting /static right with being too aggressive moving away from legacy (which I've reverted). If we want to do more with a micro-site perhaps we use something other than nanoc (Roda? 😁 )... |
AndrewHYi
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.