Skip to content

[TP-198323] Header changes#93

Merged
ssawyer1024 merged 2 commits intomasterfrom
joeu/fix/tp-198323-logo-follow-up
Jan 23, 2025
Merged

[TP-198323] Header changes#93
ssawyer1024 merged 2 commits intomasterfrom
joeu/fix/tp-198323-logo-follow-up

Conversation

@Joeu
Copy link
Copy Markdown
Contributor

@Joeu Joeu commented Jan 17, 2025

TP: https://civicplus.tpondemand.com/entity/198323-unreleased-logo-change-on-api-docs

  • Increasing header height to 70px
  • Setting logo height to 54px (used the 2x png image since it looks better on retina displays)
  • Removed the button styles for right side links
  • Removed v2 link

@Joeu Joeu self-assigned this Jan 17, 2025
@Joeu Joeu requested review from ssawyer1024 and zbeat January 17, 2025 15:22
@ssawyer1024
Copy link
Copy Markdown
Contributor

Since Zack has setup a discussion on this lets hold off until then. Otherwise I've loaded it locally and it seems to work fine.

@Joeu Joeu force-pushed the joeu/fix/tp-198323-logo-follow-up branch from 21c79c0 to e53dece Compare January 17, 2025 19:16
@Joeu Joeu changed the title feat: using svg file for logo on header [TP-198323] Header changes Jan 17, 2025
Comment thread layouts/default.html Outdated
@Joeu Joeu force-pushed the joeu/fix/tp-198323-logo-follow-up branch from e53dece to e364669 Compare January 22, 2025 19:16
Copy link
Copy Markdown
Contributor

@ssawyer1024 ssawyer1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ssawyer1024
Copy link
Copy Markdown
Contributor

Just needs Zack's 👍 on the ticket and I can merge/deploy this up.

@ssawyer1024 ssawyer1024 merged commit 96221a4 into master Jan 23, 2025
@ssawyer1024 ssawyer1024 deleted the joeu/fix/tp-198323-logo-follow-up branch January 23, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants