[TP-179336] Use postmessage instead of storage event for embedded case#2
Conversation
Gaurav0
force-pushed
the
use_postmessage_instead_of_storage_event_embedded_case
branch
5 times, most recently
from
61a4f76 to
0d44b14
Compare
Gaurav0
force-pushed
the
use_postmessage_instead_of_storage_event_embedded_case
branch
from
0d44b14 to
03437d6
Compare
Gaurav0
force-pushed
the
use_postmessage_instead_of_storage_event_embedded_case
branch
from
a53f9d9 to
35563b2
Compare
AndrewHYi
left a comment
AndrewHYi
left a comment
There was a problem hiding this comment.
suggestion: Is there a way we can run/update the torii tests?
zbeat
changed the title
|
TP story link: We need to fix the TP<>Github integration permissions, so all SCF repos are included. |
|
@AndrewHYi Tests are running automatically. |
|
@Gaurav0 nice, looks like existing tests pass - should we add tests for the new scenarios? |
| resolve(data); | ||
| }); | ||
| } | ||
| if (messageEvent.data === 'getPendingRequestKey') { |
There was a problem hiding this comment.
suggestion: this fix should be merged alongside the first commit. Also, the commit about feature flags is confusing here, but that only makes sense in the context of the SCF application (not here in Torii fork land).
| { | ||
| "name": "torii", | ||
| "version": "1.0.0-beta.2", | ||
| "version": "1.0.0-beta.3", |
There was a problem hiding this comment.
suggestion: the version bump should be the last commit - also, do we need to bump the version up again?
| @@ -0,0 +1,127 @@ | |||
| /* eslint-disable ember/no-mixins, ember/no-new-mixins, ember/no-classic-classes */ | |||
|
|
|||
| import EmberObject from '@ember/object'; | |||
There was a problem hiding this comment.
suggestion: let's add the test to the first commit.
thought: I need some help walking through the test code - I'll schedule something for this afternoon.
Update: tests seem to be failing - can reschedule the group review we rescheduled if you need more time.
Gaurav0
force-pushed
the
use_postmessage_instead_of_storage_event_embedded_case
branch
from
0442fa2 to
9332403
Compare
Gaurav0
force-pushed
the
use_postmessage_instead_of_storage_event_embedded_case
branch
from
9332403 to
154ec01
Compare
3 participants
No description provided.