Skip to content

Import prebuilt package and common scripts from MediaPipeUnityPlugin.#1

Merged
henryouly merged 5 commits intomainfrom
henryouly-project-setup
Dec 26, 2021
Merged

Import prebuilt package and common scripts from MediaPipeUnityPlugin.#1
henryouly merged 5 commits intomainfrom
henryouly-project-setup

Conversation

@henryouly
Copy link
Collaborator

@henryouly henryouly commented Dec 25, 2021

Import prebuilt package and common scripts from MediaPipeUnityPlugin

Built from commit ee27e24e963c5485a36f5a63fc7215e732f4d49f

Copied:

  • Packages/com.github.homuler.mediapipe to Assets/Packages/com.github.homuler.mediapipe
  • Assets/Mediapipe/Samples/Common to Assets/Scripts/Mediapipe/Common
  • Assets/Mediapipe/Samples/Scenes/Hand Tracking to Assets/Scripts/Mediapipe/Hand Tracking. (Deleted prefab, HandTrackingSolution and HandTrackingConfig)
  • Assets/Mediapipe/Samples/Scenes/Pose Tracking to Assets/Scripts/Mediapipe/Pose Tracking. (Deleted prefab, PoseTrackingSolution and PoseTrackingConfig)
  • Added Test.cs to make sure compilation is successful.
  • Files are copied as is.

// TODO: How to make a hello world unit test to cover this setup?

Import Unity Chan model from Unit Asset Store

  • Removed unused assets like voice and documentation.
  • Add the model to Sample Scene to test completeness.

@henryouly henryouly requested a review from wixette December 25, 2021 23:04
@henryouly henryouly self-assigned this Dec 25, 2021
@wixette
Copy link
Contributor

wixette commented Dec 26, 2021

Git LFS

Please consider using Git LFS in this project so that large asset files can be stored separately and be managed easily. Here is a sample config file for Git LFS in a Unity project:

https://github.com/SeedV/SeedCalc/blob/main/.gitattributes

3rd-party lincense

The "Unity-chan! Model" is a third-party asset released under its own license. Considering the copyright compliance, I'd suggest to add a README.md file to the dir Assets/Models/Unity-chan! Model. The file could contain the following info:

Unity-chan is an original character for developers provided by Unity Technologies Japan. It's released under the Unity-chan License.

MediaPipe is not the same case since its source code has already had its own copyright info.

Coding style

Assets/Scripts/Mediapipe/Test.cs

  1. Which coding style are we going to follow for our own C# code? SeedCalc is following the Google C# Style. I'd suggest we do the same thing here.

  2. Can Test.cs be put into a sub dir, such as /Assets/Scripts/Mediapipe/Examples?

  3. It'd be better not to name it as Test if it is not a real unittest code.

@henryouly
Copy link
Collaborator Author

Applied changes.

  • Added .gitattributes to declare metadata for LFS as suggested.
  • Added Assets/Models/Unity-chan! Model/README.md as suggested.
  • Removed Assets/Scripts/Mediapipe/Test.cs. This file is meant for temporary use. It's only used to test importing the Unity plugin and no compile error is caused by the file, and I planned to remove it in a follow-up CL. Simply skip checking in this file.

@henryouly henryouly merged commit 96b311a into main Dec 26, 2021
@henryouly henryouly deleted the henryouly-project-setup branch December 26, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants