Merged
Conversation
Collaborator
Author
|
Since I don't expect a lot of comment to this one (mostly no new code, just a nasty upstream code merge), I'm submitting the PR without review, but please feel free to comment anything that stands out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestions on how to review this change:
PoseTrackerlibmediapipe_c.dylibinPackages/com.github.homuler.mediapipe/Runtime/Plugins.Sorry for the very large change. There are pretty of incompatible changes due to development of github.com/homuler/MediaPipeUnityPlugin. The main ones are:
PoseTrackingGraphwithHolisticTrackingGraph. UpdatePoseTrackerscript to use the new graph.PoseTrackerdue to incompatible API changes.PoseTrackerto create SidePacket and send it to the graph.StreamingAssets.MacOS/arm64.Assets/Pluginsto top-levelPackages/.It also upgraded Editor version to 2021.3.0f1.
Changes are tested in dev branch to make sure the scene is loaded and functionality is not broken.