Skip to content

Upgrade MediaPipeUnityPlugin to v0.9.0.#12

Merged
henryouly merged 1 commit intomainfrom
henryouly-new-mediapipe
Apr 16, 2022
Merged

Upgrade MediaPipeUnityPlugin to v0.9.0.#12
henryouly merged 1 commit intomainfrom
henryouly-new-mediapipe

Conversation

@henryouly
Copy link
Collaborator

@henryouly henryouly commented Apr 16, 2022

Suggestions on how to review this change:

  1. Review changes in PoseTracker
  2. Verify the move of plugin folder.
  3. Verify integrity of the change, e.g. checkout and load the project in unity and load the scene. I have only been able to support M1 Mac though, so Intel Mac should build the plugin from source in upstream project and put the created libmediapipe_c.dylib in Packages/com.github.homuler.mediapipe/Runtime/Plugins.

Sorry for the very large change. There are pretty of incompatible changes due to development of github.com/homuler/MediaPipeUnityPlugin. The main ones are:

  • Check out MediaPipeUnityPlugin@v0.9.0 and recompile the plugin on M1 (Apple Silicon).
  • Pull in new C# scripts from its sample project.
  • Replace PoseTrackingGraph with HolisticTrackingGraph. Update PoseTracker script to use the new graph.
  • Update PoseTracker due to incompatible API changes.
  • Update some upstream code to allow classes like PoseTracker to create SidePacket and send it to the graph.
  • Removed unrelated models in StreamingAssets.
  • Move the M1 plugin under MacOS/arm64.
  • Move the plugin package from Assets/Plugins to top-level Packages/.

It also upgraded Editor version to 2021.3.0f1.

Changes are tested in dev branch to make sure the scene is loaded and functionality is not broken.

@henryouly henryouly requested a review from wixette April 16, 2022 21:08
@henryouly
Copy link
Collaborator Author

Since I don't expect a lot of comment to this one (mostly no new code, just a nasty upstream code merge), I'm submitting the PR without review, but please feel free to comment anything that stands out.

@henryouly henryouly merged commit 24882e4 into main Apr 16, 2022
henryouly added a commit that referenced this pull request Apr 16, 2022
@henryouly henryouly deleted the henryouly-new-mediapipe branch April 18, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant