Conversation
This was referenced Jun 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change FaceRotation from Euler angle to Quaternion. It appears to fix the issue.
Previous PR (#24) did not fix the issue. The recognition still sometimes get the movement direction (up/down, left/right) inverted. It's hard to 100% repro on each run.
I suspect the previous implementation has problems specific to Euler angles, like gimbal lock.
Side effect: The clamping of face rotation is removed, however, it doesn't seem to be necessary from my current testing, but we can add it back if there's a requirement to clamp at a max angle.
References:
https://answers.unity.com/questions/1266985/convert-rotation-vector-or-matrix-to-quaternion.html
yuenshome/yuenshome.github.io#9
Fix #19