Conversation
henryouly
reviewed
Jun 16, 2022
henryouly
reviewed
Jun 16, 2022
henryouly
reviewed
Jun 16, 2022
henryouly
requested changes
Jun 16, 2022
Collaborator
henryouly
left a comment
henryouly
left a comment
There was a problem hiding this comment.
Please follow the naming convention when placing multi-arch binaries to the project.
[plugin name] ---> [OS platform] ---> [CPU architect]
e.g. for opencv plugin:
Plugins
|----opencvplugin
|---- MacOS
| |---- arm64
| |---- x86_64
|---- Windows
|---- x64
The previous plugin directory doesn't follow this, please move the M1 opencvplugin into its proper location.
henryouly
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.