Merged
Conversation
wixette
approved these changes
Dec 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the full-screen canvas into a 3D
Quadwith the rendering material of the video clip. The video clip is output to the RenderTexture (either from webcam or video source)This should fit our demo better because the fullscreen video playback is too distracting if also placing the Unity-chan model in the scene. The new
Quadcan be resize and place further away like a Theater screen if needed.As the result, we don't need to specify the
_mainUI(aRawImage) in theInputController, as the texture will automatically applied to the material of theQuad, so removing for simplicity.Additionally: minor changes to
InputController.Startsince it doesn't need to be the coroutine version.