first effort to add segment #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionzualo
previously requested changes
Nov 15, 2016
lib/analytical/modules/segment.rb
Outdated
| @@ -0,0 +1,130 @@ | |||
| module Analytical | |||
| module Modules | |||
There was a problem hiding this comment.
I don't know if the problem is from the GitHub's diff but it seems you are using tabs when you actually should use (2) spaces for indentation across the whole file.
lib/analytical/modules/segment.rb
Outdated
| end | ||
|
|
||
| def init_javascript(location) | ||
| init_location(location) do |
There was a problem hiding this comment.
The appropriate indentation for this method would be something along the lines of:
def init_javascript(location)
init_location(location) do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.