Ga label update #23
Merged
Ga label update #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsorros
force-pushed
the
ga-label-update
branch
from
df9cd63 to
a976fc0
Compare
sergiopatricio
approved these changes
Dec 19, 2016
sergiopatricio
left a comment
sergiopatricio
left a comment
There was a problem hiding this comment.
After having this, do we still need the events in the form /virtual/event/...?
(I don't know where exactly they are used, just have an idea that they were used for some kind of conversion track)
Author
|
@sergiopatricio They can probably be deleted but I have flagged this as a low priority for now. It is something I will investigate as soon as the first pass of my GA reviews finishes but thanks for flagging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When an event gets sent to Google analytics all the properties (options) are lost since GA only supports sending a category, action, label and value argument along with the event.
https://developers.google.com/analytics/devguides/collection/analyticsjs/events
Proposed solution
I suggest we stringify the properties and add them in the event label. This will allow us to differentiate events between each other by using a match regex filter.
http://stackoverflow.com/questions/25373015/google-analytics-event-tracking-with-multiple-labels
Use case
I want to set up a goal for first and repeat investment. I have no way to differentiate by the investment count property since it is not passed in GA.