WS order_by allow both str and enum input#87
Merged
robbieaverill merged 8 commits intoSeequentEvo:mainfrom Jul 30, 2025
Merged
Conversation
Gibson-Seequent
approved these changes
Jul 17, 2025
Contributor
robbieaverill
left a comment
robbieaverill
left a comment
There was a problem hiding this comment.
Hey @lokkochan, thanks for the PR! I've left a question about the enum handling.
wordsworthc
reviewed
Jul 27, 2025
wordsworthc
approved these changes
Jul 28, 2025
robbieaverill
approved these changes
Jul 30, 2025
Contributor
robbieaverill
left a comment
robbieaverill
left a comment
There was a problem hiding this comment.
IMO, we can remove the enum typing and just have the new Literal types. Happy to merge in its current state though. Thanks @lokkochan!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
order_by is taking in enum, but is not converted to string before processing them in next layer. This result in 422 as enum instead of str is being passed in. (Issue for python3.11 or higher)
Allow both str and enum input and client preprocess them into string if is enum being passed in
Checklist