get the race leader #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturNurtdinov
left a comment
ArturNurtdinov
left a comment
There was a problem hiding this comment.
Очень хорошая работа, молодец!
Comment on lines
+2
to
+3
| public String name; | ||
| public int speed; |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
| public class Race { | ||
| private final static int RACE_TIME = 24; | ||
|
|
||
| public String leader; |
There was a problem hiding this comment.
Данную переменную лучше сделать приватной, чтобы снаружи класса нельзя было её поменять, тем самым сломав логику работы этого класса (т.к. переменная должна менять своё значение только в функции checkLeader). Для получения имени победителя лучше написать отдельную функцию-геттер
| System.out.println("— Введите скорость машины №" + i + ": "); | ||
| carSpeedStr = scanner.nextLine().trim(); | ||
|
|
||
| if (!carSpeedStr.matches("-?\\d+")) { |
There was a problem hiding this comment.
Регулярное выражение тоже лучше вынести в константу с говорящим названием, чтобы повысить читабельность кода
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Создание консольного приложения "24 часа Ле-Мана"