Skip to content

Reset pixel segments collection at start#161

Merged
ariostas merged 1 commit intomasterfrom
ariostas/reset_pixelsegments_col
Mar 25, 2025
Merged

Reset pixel segments collection at start#161
ariostas merged 1 commit intomasterfrom
ariostas/reset_pixelsegments_col

Conversation

@ariostas
Copy link
Copy Markdown
Member

The pixel segments collection was not being reset, so it was causing some issues. I'm surprised that it was only noticeable on GPU and not on CPU.

@GNiendorf could you verify that this fixes the issue?

@GNiendorf
Copy link
Copy Markdown
Member

Just checked this PR, the performance plots look good now. Memory usage looks unchanged with/without this fix. Thank you again for finding this

@slava77
Copy link
Copy Markdown

slava77 commented Mar 21, 2025

/run all

@slava77
Copy link
Copy Markdown

slava77 commented Mar 21, 2025

I think that this can go upstream directly.

@github-actions
Copy link
Copy Markdown

The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.

Efficiency vs pT comparison Efficiency vs eta comparison
Fake rate vs pT comparison Fake rate vs eta comparison
Duplicate rate vs pT comparison Duplicate rate vs eta comparison

The full set of validation and comparison plots can be found here.

Here is a timing comparison:

   Evt    Hits       MD       LS      T3       T5       pLS       pT5      pT3      TC       Reset    Event     Short             Rate
   avg     32.5    381.6    187.6    150.8    166.7    707.9    132.4    237.1    179.0      1.7    2177.2    1436.8+/- 406.3     577.1   explicit[s=4] (target branch)
   avg     29.1    382.0    190.4    151.9    145.9    622.9    129.8    236.0    167.3      1.9    2057.3    1405.2+/- 386.2     545.8   explicit[s=4] (this PR)

@github-actions
Copy link
Copy Markdown

The PR was built and ran successfully with CMSSW. Here are some plots.

OOTB All Tracks
Efficiency and fake rate vs pT, eta, and phi

The full set of validation and comparison plots can be found here.

@ariostas ariostas merged commit a46bc8b into master Mar 25, 2025
3 checks passed
@ariostas ariostas deleted the ariostas/reset_pixelsegments_col branch May 19, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants