feat: add updatePointProperties()#3
Merged
Conversation
Max-Verbinnen
approved these changes
Aug 19, 2025
Max-Verbinnen
left a comment
Max-Verbinnen
left a comment
There was a problem hiding this comment.
nice, i like the design of the new method :)
| } | ||
|
|
||
| updatePointProperties(point) { | ||
| const id = this._linearSearchInPoints(point); |
There was a problem hiding this comment.
iiuc, this should be idx instead of id
|
|
||
| updatePointProperties(point) { | ||
| const id = this._linearSearchInPoints(point); | ||
| if (!id) return; |
There was a problem hiding this comment.
maybe we should also throw an error in this case?
Comment on lines
+426
to
+432
| const pointId = this.getId(point); | ||
| for (let i = 0; i < this.points.length; i++) { | ||
| if (this.getId(this.points[i]) === pointId) { | ||
| return i; | ||
| } | ||
| } | ||
| return null; |
There was a problem hiding this comment.
Suggested change
| const pointId = this.getId(point); | |
| for (let i = 0; i < this.points.length; i++) { | |
| if (this.getId(this.points[i]) === pointId) { | |
| return i; | |
| } | |
| } | |
| return null; | |
| const pointId = this.getId(point); | |
| const index = this.points.findIndex(p => this.getId(p) === pointId); | |
| return index !== -1 ? index : null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the first new method in the mutable supercluster. This method allows you to update a point to a given point. This method only takes effect when the id of the provided point corresponds to a point-id in the cluster, and the updated point has the same location.