Update Workflow#18
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reorganizes MSBuild configuration by moving shared build/analyzer settings into src/Directory.Build.Props and adjusting the solution’s Solution Items accordingly.
Changes:
- Added
src/Directory.Build.Propscontaining shared compiler/analyzer settings (nullable, analyzers, warnings-as-errors, etc.). - Removed the previous configuration content from the repository-root
Directory.Build.Props(now effectively empty). - Updated
CodeClash.slnto includesrc/Directory.Build.Propsas a Solution Item under thesrcsolution folder.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Directory.Build.Props | Introduces shared build/analyzer configuration scoped to projects under src/. |
| Directory.Build.Props | Removes prior build/analyzer configuration content (leaves an empty props file). |
| CodeClash.sln | Adds src/Directory.Build.Props to Solution Items under the src solution folder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,24 +1,2 @@ | |||
| <Project> | |||
There was a problem hiding this comment.
The repo now has two Directory.Build.Props files: the root one is empty, while the real build settings live under src/. Keeping an empty root props (and still listing it as a Solution Item) is confusing and can lead to future projects outside src not inheriting the same analysis settings. Consider either deleting the root Directory.Build.Props, or having the root file import the src one (and/or keep the shared settings in one place).
| <Project> | |
| <Project> | |
| <Import Project="$(MSBuildThisFileDirectory)src\Directory.Build.Props" /> |
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{02EA681E-C7D8-13C7-8484-4AC65E1B71E8}" | ||
| ProjectSection(SolutionItems) = preProject | ||
| src\Directory.Build.Props = src\Directory.Build.Props | ||
| EndProjectSection |
There was a problem hiding this comment.
PR title suggests workflow changes, but this diff updates solution items and relocates build configuration (Directory.Build.Props). If the intent is to update CI/GitHub Actions, consider also updating the workflow files or retitling the PR so the change matches its stated purpose.
No description provided.