Skip to content

Refactor ExecutionService and remove memory tracking#31

Merged
SeifMohmmed merged 1 commit into
masterfrom
feature/application-layer-cqrs
May 25, 2026
Merged

Refactor ExecutionService and remove memory tracking#31
SeifMohmmed merged 1 commit into
masterfrom
feature/application-layer-cqrs

Conversation

@SeifMohmmed
Copy link
Copy Markdown
Owner

Changes:
Simplified the RunCodeAsync method by removing the memoryLimit parameter and all memory tracking logic. Refactored ExecutionService to improve maintainability, including:

  • Introduced CleanupAsync for resource cleanup and added IDisposable implementation.
  • Updated _containerId to nullable and improved Docker container lifecycle management.
  • Consolidated file path handling with consistent naming conventions.
  • Simplified Docker command creation to focus on runtime limits.
  • Enhanced response classes (AcceptedResponse, WrongAnswerResponse, etc.) with additional fields for better debugging.
  • Refactored CalculateResult to use a shared method for reading execution outputs.
  • Removed legacy code and unused methods for better maintainability.

Improved error handling, updated Docker container configuration, and enhanced test case handling. These changes make the codebase cleaner, more robust, and easier to extend.

Copilot AI review requested due to automatic review settings May 25, 2026 18:57
@SeifMohmmed SeifMohmmed merged commit c04c8ca into master May 25, 2026
1 check failed
@SeifMohmmed SeifMohmmed review requested due to automatic review settings May 25, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant