Skip to content

feat: move to taskfiles#79

Merged
JonZeolla merged 43 commits intomainfrom
task-refactor
Jul 18, 2023
Merged

feat: move to taskfiles#79
JonZeolla merged 43 commits intomainfrom
task-refactor

Conversation

@seanctech
Copy link
Copy Markdown
Member

@seanctech seanctech commented Feb 18, 2023

Contributor Comments

Added submodule for goat to include centralized Taskfiles.
Added default Taskfile for generated projects.

Pull Request Checklist

Thank you for submitting a contribution to cookiecutter-python!

In order to streamline the review of your contribution we ask that you review
and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch.
  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • If there is an issue associated with your Pull Request, link the issue to the PR.
  • Validate that documentation is accurate and aligned to any project updates or additions.

@seanctech seanctech requested a review from JonZeolla as a code owner February 18, 2023 02:20
JonZeolla
JonZeolla requested changes Feb 19, 2023
View reviewed changes
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yaml Outdated
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yaml Outdated
@JonZeolla
Copy link
Copy Markdown
Member

JonZeolla commented Feb 19, 2023 •
edited
Loading

@JonZeolla
Copy link
Copy Markdown
Member

JonZeolla commented Feb 19, 2023

Fixed linting

@JonZeolla
Copy link
Copy Markdown
Member

JonZeolla commented Mar 16, 2023 •
edited
Loading

  • Add to setup.cfg under [metadata] a releasetype key and a value of either calver or semver, which the goat can then use to detect release type

@JonZeolla JonZeolla mentioned this pull request Mar 16, 2023
Merged
4 tasks
JonZeolla
JonZeolla requested changes Mar 21, 2023
View reviewed changes
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yaml
JonZeolla
JonZeolla reviewed Mar 22, 2023
View reviewed changes
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yaml Outdated
JonZeolla
JonZeolla requested changes Mar 23, 2023
View reviewed changes
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yaml
JonZeolla
JonZeolla reviewed Mar 24, 2023
View reviewed changes
Comment thread hooks/post_gen_project.py Outdated
JonZeolla
JonZeolla reviewed Mar 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this?

Comment thread hooks/post_gen_project.py Outdated
Comment thread hooks/post_gen_project.py Outdated
Comment thread hooks/post_gen_project.py Outdated
JonZeolla
JonZeolla reviewed Mar 24, 2023
View reviewed changes
Comment thread hooks/post_gen_project.py Outdated
Comment thread hooks/post_gen_project.py Outdated
Comment thread hooks/post_gen_project.py Outdated
Comment thread hooks/post_gen_project.py Outdated
@JonZeolla JonZeolla changed the title cleaning up old work feat: move to taskfiles Mar 25, 2023
@JonZeolla
Copy link
Copy Markdown
Member

JonZeolla commented Mar 25, 2023

@seanctech there still seems to be a lot to do here. The pipelines are still using invoke so they need to be cut over to task, and we haven't aligned the parent project either.

JonZeolla
JonZeolla reviewed Mar 31, 2023
View reviewed changes
Comment thread hooks/post_gen_project.py
@JonZeolla
Copy link
Copy Markdown
Member

JonZeolla commented Apr 13, 2023 •
edited
Loading

  • Using sources and generates seems to work as expected, but we need to add .task/* to the gitignore here so it doesn't check in the checksums, etc.

More details in the related Wrike task

@JonZeolla
Copy link
Copy Markdown
Member

JonZeolla commented May 12, 2023

The generated read me is wrong too

JonZeolla
JonZeolla requested changes Jun 26, 2023
View reviewed changes
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yml
Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yml
JonZeolla
JonZeolla approved these changes Jul 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@JonZeolla JonZeolla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 (but need linting and testing to pass)

Comment thread {{cookiecutter.project_name|replace(" ", "")}}/Taskfile.yml
JonZeolla
JonZeolla requested changes Jul 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also missing a migration of the parent project to taskfile using the same logic in the generated project. Please update it

@seanctech seanctech requested a review from a team as a code owner July 18, 2023 15:45
JonZeolla
JonZeolla previously approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

@JonZeolla JonZeolla enabled auto-merge (squash) July 18, 2023 21:42
@JonZeolla JonZeolla merged commit 71c942b into main Jul 18, 2023
@JonZeolla JonZeolla deleted the task-refactor branch July 18, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonZeolla JonZeolla JonZeolla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanctech @JonZeolla