Skip to content

ci: Tightly couple caches to the lockfile hash#91

Merged
JonZeolla merged 4 commits intomainfrom
fix/actions/cache
Aug 21, 2023
Merged

ci: Tightly couple caches to the lockfile hash#91
JonZeolla merged 4 commits intomainfrom
fix/actions/cache

Conversation

@JonZeolla
Copy link
Copy Markdown
Member

@JonZeolla JonZeolla commented Aug 3, 2023

Contributor Comments

In the past we restored venv files based on fuzzy matching logic that didn't include a hash of the lockfile. This has caused old issues to come back to live and has been very frustrating, so we are going to be more specific about cache restoration.

Pull Request Checklist

Thank you for submitting a contribution to cookiecutter-python!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

@JonZeolla JonZeolla requested review from a team and seanctech as code owners August 3, 2023 20:06
@JonZeolla JonZeolla enabled auto-merge (squash) August 3, 2023 20:06
seanctech
seanctech previously approved these changes Aug 4, 2023
Copy link
Copy Markdown
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JonZeolla JonZeolla added the blocked Unable to make progress label Aug 21, 2023
Copy link
Copy Markdown
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JonZeolla JonZeolla removed the blocked Unable to make progress label Aug 21, 2023
@JonZeolla JonZeolla disabled auto-merge August 21, 2023 17:49
@JonZeolla JonZeolla enabled auto-merge (squash) August 21, 2023 17:49
@JonZeolla JonZeolla disabled auto-merge August 21, 2023 17:50
@JonZeolla JonZeolla merged commit b26df94 into main Aug 21, 2023
@JonZeolla JonZeolla deleted the fix/actions/cache branch August 21, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants