Conversation
callmestu
approved these changes
Aug 15, 2023
callmestu
left a comment
callmestu
left a comment
There was a problem hiding this comment.
LGTM - lots of good additions. Observing the practice of pointing out SPoF whenever I see them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Comments
This adds more context to our docs
Pull Request Checklist
Thank you for submitting a contribution to cookiecutter-python!
In order to streamline the review of your contribution we ask that you review and comply with the below requirements:
Don't forget our more detailed contribution guidelines
here.