-
Notifications
You must be signed in to change notification settings - Fork 855
docs: broken link checker #6628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| - uses: actions/checkout@master | ||
|
|
||
| - name: Check links | ||
| uses: gaurav-nelson/github-action-markdown-link-check@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rajakavitha1 could you please share why did you choose this package?
For mpm we used umbrelladocs/action-linkspector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the one of recommended checker. To maintain consistency I guess it is best to go with umbrelladocs/action-linkspector. @tyndria Please feel free to make any changes that you deem right for the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tyndria I noticed that for SEP we are using: https://github.com/SeldonIO/SEP-docs/blob/master/.github/workflows/daily-link-checker.yml. Can you please confirm the package that you plan to use across the products.
Why
Issues
Motivation
What
Summary of changes
Checklist
Testing