Skip to content

Conversation

@Rajakavitha1
Copy link
Contributor

Why

Issues

Motivation

What

Summary of changes

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ Rajakavitha1
❌ Rakavitha Kodhandapani
❌ monica-seldon


Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

- uses: actions/checkout@master

- name: Check links
uses: gaurav-nelson/github-action-markdown-link-check@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajakavitha1 could you please share why did you choose this package?
For mpm we used umbrelladocs/action-linkspector

Copy link
Contributor Author

@Rajakavitha1 Rajakavitha1 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the one of recommended checker. To maintain consistency I guess it is best to go with umbrelladocs/action-linkspector. @tyndria Please feel free to make any changes that you deem right for the docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tyndria I noticed that for SEP we are using: https://github.com/SeldonIO/SEP-docs/blob/master/.github/workflows/daily-link-checker.yml. Can you please confirm the package that you plan to use across the products.

@paulb-seldon paulb-seldon merged commit c32b2df into master Jul 31, 2025
9 of 14 checks passed
@paulb-seldon paulb-seldon deleted the rajie-brokenlinks branch July 31, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants