Skip to content

Conversation

@vtaskow
Copy link
Contributor

@vtaskow vtaskow commented Dec 17, 2025

What

Summary of changes

  • Copy over code from Ramon's PR - XGBoost runtime fixes #5938
  • Add requirements-dev.txt file
  • Move .gitignore + ignore both model.bst and model.json (created by running the notebook)
  • Write a README.md
  • In the XGBoostServer class - add 2 checks for validating the input(on top of Ramon's code)

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

The Jupyter notebook runs file + tests

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vtaskow vtaskow requested a review from tyndria December 17, 2025 17:32
Copy link
Contributor

@tyndria tyndria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! I propose to close Ramon's PR!

@tyndria tyndria merged commit febf394 into SeldonIO:release-1.19.0-prep Dec 18, 2025
15 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants