-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Roll back default value of SE_DISTRIBUTOR_SLOT_SELECTOR
as empty
#2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #2990
An empty value means the default slot selector will be used,
org.openqa.selenium.grid.distributor.selector.DefaultSlotSelector
.For
GreedySlotSelector
, the user has to explicitly set it.Update details of these 2 built-in slot selectors in README.
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Roll back
SE_DISTRIBUTOR_SLOT_SELECTOR
default from GreedySlotSelector to emptyUpdate documentation to clarify slot selector behavior and built-in implementations
Explain DefaultSlotSelector as Grid's default strategy when not configured
Document GreedySlotSelector as alternative for resource-intensive scenarios
Diagram Walkthrough
File Walkthrough
Dockerfile
Reset slot selector default to empty
Base/Dockerfile
SE_DISTRIBUTOR_SLOT_SELECTOR
environment variable defaultvalue from
org.openqa.selenium.grid.distributor.selector.GreedySlotSelector
toempty string
ENV_VARIABLES.md
Update slot selector documentation and defaults
ENV_VARIABLES.md
SE_DISTRIBUTOR_SLOT_SELECTOR
fromGreedySlotSelector class name to empty
default strategy and GreedySlotSelector as an alternative
README.md
Add comprehensive slot selector documentation
README.md
SE_DISTRIBUTOR_SLOT_SELECTOR
to Distributor configuration tablewith empty default value
implementations
least-recently-used strategy
and high-concurrency scenarios
description.yaml
Update slot selector description reference
scripts/generate_list_env_vars/description.yaml
alternative instead of DefaultSlotSelector as default
value.yaml
Reset slot selector default value
scripts/generate_list_env_vars/value.yaml
SE_DISTRIBUTOR_SLOT_SELECTOR
fromorg.openqa.selenium.grid.distributor.selector.GreedySlotSelector
toempty string