-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[ci] Start test site the-internet localhost in CI using container #2998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||||||||
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
2cd3a51 to
ea1ba65
Compare
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
ea1ba65 to
ba04cf1
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Test site https://the-internet.herokuapp.com/ get down or unstable sometime, which impact CI tests.
Get source packaged in container and start it with the tests locally.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Replace hardcoded test site URLs with configurable localhost container
Add TEST_SITE environment variable support across all test frameworks
Implement Docker container startup for the-internet test site in CI
Update Python, Java, and TypeScript tests to use dynamic test site URL
Diagram Walkthrough
File Walkthrough
__init__.py
Replace hardcoded URLs with configurable TEST_SITE variabletests/SeleniumTests/init.py
TEST_SITEenvironment variable with defaulthost.docker.internal:5001the-internet.herokuapp.comURLs with dynamicTEST_SITEvariableTEST_SITESeleniumTests.java
Add configurable TEST_SITE to Java test classtests/SeleniumJavaTests/src/test/java/SeleniumTests.java
TEST_SITEfield initialized from environment variable with defaultvalue
the-internet.herokuapp.comURLs withString.format()using
TEST_SITETests.ts
Implement TEST_SITE configuration in TypeScript teststests/CDPTests/tests/Tests.ts
TEST_SITEandTEST_URLconstants from environment variablethe-internet.herokuapp.comURLs withTEST_URLvariable
Makefile
Add Makefile target to start test site containerMakefile
start_test_sitetarget to start the-internet Docker containerchart_test.sh
Export TEST_SITE environment variable for teststests/charts/make/chart_test.sh
TEST_SITEenvironment variable set tolocalhost:5001docker-test.yml
Add test site startup step to docker-test workflow.github/workflows/docker-test.yml
make start_test_sitein CI pipelinehelm-chart-test.yml
Add test site startup step to helm-chart-test workflow.github/workflows/helm-chart-test.yml
make start_test_sitein CI pipelinek8s-scaling-test.yml
Add test site startup step to k8s-scaling-test workflow.github/workflows/k8s-scaling-test.yml
make start_test_sitein CI pipeline