Time for timeout parameters should be in ms in command line help

[oflorko]

Meta -

OS: Any console

Selenium Version: >= 3.0.0

Browser: N/A

Browser Version: N/A

Expected Behavior -

In console help all timing parameters should be in ms.

Actual Behavior -

Wrong time dimensions for parameters related to timeouts in console help.
-browserTimeout
in seconds
-timeout, -sessionTimeout
in seconds

Steps to reproduce -

Type in command line java -jar selenium-server-standalone-3.6.0.jar --help

[barancev]

Why should they be in milliseconds?

[mmerrell]

If I’m correct, Olena is indicating that they’re documented incorrectly. She attended the Grid workshop in Berlin and reported this issue during the workshop, but I didn’t have time to investigate then. I know that some options are in ms and some are in seconds, and I once went through and reconciled the code with the options, but she indicated that some were incorrectly documented. I thought it would be worth double-checking on the code side. I can take this one. MM

…

Sent from my iPhone

On Oct 18, 2017, at 6:45 AM, Alexei Barantsev ***@***.***> wrote: Why should they be in milliseconds? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[kool79]

In grid v2.x all timeouts in json configuration files were in ms. But during migration to grid v3.8 I found that timeout () and browserTimeout now should be in seconds (in json). I don't expect those changes because all parameter's names remain the same. I found this only after exploring source code of grid server. (I dont trust docs because they have erorrs before). It is very uncomfortable and error-prone to have different time units in the same configuration file: some timeouts in ms (nodeStatusCheckTimeout, unregisterIfStillDownAfter, newSessionWaitTimeout etc) while others (timeout, browserTimeout) use seconds.
For example, official appium documentation (at the moment, http://appium.io/slate/en/master/?ruby#selenium-grid) contains timeout in seconds
I think this happens when code for configuration/cli parsing was refactored. Because both those parameters were ms in json but sec in command line interface.
So for now we have a lot of people//documentation/guides with old configs (with ms), while some peoples switched to sec. New config is very confusing (see for example , #2973)

[romankovsv]

Very annoying bug which leads to error-prone configuration could you fix it ?

[mmerrell]

Pull requests are welcome. This is a volunteer-led project, and sometimes life gets in the way. I still might be able to get to it, but it sounds like your annoyance level is sufficiently high to merit some sort of effort...

[diemol]

Closing this as Grid 3.x is not under development anymore, please try Grid 4 (which is in the alphas) https://www.selenium.dev/downloads/. Documentation updates are in progress.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.