Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upbrowserTimeout parameter and BROWSER_TIMEOUT reason are confusing and inconsistent #6370
Comments
diemol
added
the
C-grid
label
Sep 5, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kool79
commented
Sep 5, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
diemol
closed this
Sep 14, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
oleksandr-kulychok
Sep 14, 2018
@diemol ,
What about 2nd part of issue :
Hub continues to return error codes with message "Session [...] was terminated due to BROWSER_TIMEOUT" which is confusing and has nothing common with browserTimeout parameter. Currently this error reason is returned by hub to clients (tests) after remote node returns 404 error - 'no such session', See TestSession#closeSessionIfNecessary lines 301, 323, 330
I.e. clients (tests) get wrong exceptions that "session terminated due to browser_timeout" but in fact it is not the case. Due that behavior it is very hard to understand the real rootcause of issue and can be confusing both for test automation engineers and for Selenium support team.
oleksandr-kulychok
commented
Sep 14, 2018
|
@diemol ,
I.e. clients (tests) get wrong exceptions that "session terminated due to browser_timeout" but in fact it is not the case. Due that behavior it is very hard to understand the real rootcause of issue and can be confusing both for test automation engineers and for Selenium support team. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
diemol
Sep 15, 2018
Member
clients (tests) get wrong exceptions that "session terminated due to browser_timeout" but in fact it is not the case
Why do you say that? Do you have an example where that is not the case? (Also take into account that browserTimeout is broken right now, so this is probably a cascade of wrong exceptions due to that).
Why do you say that? Do you have an example where that is not the case? (Also take into account that |
kool79 commentedSep 5, 2018
Parameter browserTimeout does nothing (actually not used).
The last time it was used is pre-3.9 version in java/server/src/org/openqa/selenium/remote/server/DriverServlet.java, (file deleted in commit 0811736)
Currently both OKHttp and Apache use timeout with duration==3 hours which sometimes hangs test (for example, when Authentication required but not provided or when broconnection interrupted/died) (Thats why test BrowserTimeOutTest is broken)
Hub continues to return error codes with message "Session [...] was terminated due to BROWSER_TIMEOUT" which is confusing and has nothing common with browserTimeout parameter. Currently this error reason is returned by hub to clients (tests) after remote node returns 404 error - 'no such session', See
TestSession#closeSessionIfNecessarylines 301, 323, 330But behavior is specific - During first request (after session is gone) client gets error "no such session" (proxied by hub) but all subsequent requests return error "browser_timeout":
Of cause wrong reason is not so critical issue but it significantly complicates process of grid environment configuration, logs analysing, investigation of error reasond etc.
Proposed fix for item 1: when initialise proxy httpClient use
browserTimeoutparameter to instead of using default constant value (3h) for apache and okhttp clientsProposed fix for item 2: