Skip to content

PEP484 type hints for py/selenium/webdriver/chrome/options.py #10212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2022
Merged

PEP484 type hints for py/selenium/webdriver/chrome/options.py #10212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1a807b
PEP484 hints for py/selenium/webdriver/chrome/options.py
thecr8tr Jan 1, 2022
be4200b
PEP484 hints for py/selenium/webdriver/chrome/options.py
thecr8tr Jan 1, 2022
411b82d
PEP484 hints for py/selenium/webdriver/chrome/webdriver.py
thecr8tr Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion py/selenium/webdriver/chrome/options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

from selenium.webdriver.chromium.options import ChromiumOptions
from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
from typing import Optional


class Options(ChromiumOptions):
Expand All @@ -25,5 +26,9 @@ class Options(ChromiumOptions):
def default_capabilities(self) -> dict:
return DesiredCapabilities.CHROME.copy()

def enable_mobile(self, android_package="com.android.chrome", android_activity=None, device_serial=None):
def enable_mobile(self,
android_package: str = "com.android.chrome",
android_activity: Optional[str] = None,
device_serial: Optional[str] = None
) -> None:
super().enable_mobile(android_package, android_activity, device_serial)