firefox: Throw error when element cannot be clicked#1211
Closed
p0deje wants to merge 1 commit intoSeleniumHQ:masterfrom
Closed
firefox: Throw error when element cannot be clicked#1211p0deje wants to merge 1 commit intoSeleniumHQ:masterfrom
p0deje wants to merge 1 commit intoSeleniumHQ:masterfrom
Conversation
Current behavior is that when element is overlapped by another one, trying to click it will silent fail because click is happening on overlapping element. This commit changes the behavior so instead error is thrown telling that overlapping element would receive click. It makes the behavior mostly similar to ChromeDriver.
p0deje
force-pushed
the
fxdriver-element-not-clickable
branch
from
db54e14 to
51bef0c
Compare
Member
|
Merged in a240141 |
|
Is exeption expected when all you need to do is scroll the page. such that element becomes visible ?! |
Member
|
@vveliev Yes, Selenium scrolls the target element to the view port. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior is that when element is overlapped by another one,
trying to click it will silent fail because click is happening on
overlapping element. This commit changes the behavior so instead error
is thrown telling that overlapping element would receive click. It makes
the behavior mostly similar to ChromeDriver.
I've implemented this after it was mentioned on IRC that this behavior might make sense and after a bunch of issues were reported (#1202, #1204, #1166).
That is my first time I deal with FirefoxDriver, so the code may not be the best. Also, there is now some duplication with
webdriver.chrome.isElementClickablefunction so maybe it makes sense to DRY it up. Also, since I don't have much experience with Java/JavaScript testing of Selenium, it was easier for me to add regression test in Ruby.@barancev @lukeis Please, take a look.