Fix double rejection error caused by findElement in WebDriverJs.#141
Closed
jagoda wants to merge 1 commit intoSeleniumHQ:masterfrom
Closed
Fix double rejection error caused by findElement in WebDriverJs.#141jagoda wants to merge 1 commit intoSeleniumHQ:masterfrom
jagoda wants to merge 1 commit intoSeleniumHQ:masterfrom
Conversation
Contributor
|
Thanks for the patch! The problem is actually a bug with Deferred#cancel(). Will push a fix momentarily. Closing pull request. |
Author
|
Ah, cool, thanks! |
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
… Message. Add method to serialize a Request to a byte array without storing the bytes in the Message.bytes property. This way, client code that is only interested in getting the wire format encoding for a request does not need to make a decision on a particular wire format to be used when the the message is ultimately sent out. Also improved JavaDocs and test cases.
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
Fix memory leak introduced by cloning the request once only when inserting observation into store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue 6686. See the issue in Google code for more details: https://code.google.com/p/selenium/issues/detail?id=6686
I have signed the CLA.